[webkit-reviews] review granted: [Bug 174430] Add iOS 11 SPI : [Attachment 315497] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 174430: Add iOS 11 SPI
https://bugs.webkit.org/show_bug.cgi?id=174430

Attachment 315497: Patch

https://bugs.webkit.org/attachment.cgi?id=315497&action=review




--- Comment #15 from Tim Horton <thorton at apple.com> ---
Comment on attachment 315497
  --> https://bugs.webkit.org/attachment.cgi?id=315497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315497&action=review

> Source/WTF/Configurations/WTF.xcconfig:33
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=iphonesimulator11*] =
$(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK))

This should be inverted so that it remains true in future.

> Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h:44
> +// iOS 11 has this value defined.

I don't think we need the comment.

> Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:135
> ++ (CATransactionPhase) currentPhase;

No space after the ). Also this is available on Mac too!

> Source/WebCore/platform/spi/ios/UIKitSPI.h:88
> + at interface NSURL (UIKit_Private)

Leave all the category names blank (make them class extensions or whatever)

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:310
> +#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90100

I can't imagine we still need this

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:332
> + at property (nonatomic, setter=_setContentInsetAdjustmentBehavior:,
getter=_contentInsetAdjustmentBehavior)
UIScrollViewContentInsetAdjustmentBehavior _contentInsetAdjustmentBehavior;

Shoudn't need this. If anybody's calling it, they should be using the one
without the underscore.

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:341
> + at interface UITapGestureRecognizer (UITapGestureRecognizer)

Blank

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:915
> ++ (UITextEffectsWindow *) sharedTextEffectsWindow;

No space after )

> Source/WebKitLegacy/Storage/StorageTracker.cpp:44
> -#include <sqlite3_private.h>
> +#define SQLITE_TRUNCATE_DATABASE 101

You should be able to use your nice SPI header if you just make it private
(like some of the other WebCore ones are!).

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:49
> ++ (UIItemProvider *) itemProviderWithURL:(NSURL *)url title:(NSString
*)title;

Spaces after ) again

> Tools/TestWebKitAPI/ios/DataInteractionSimulator.h:40
> + at interface NSURL (UIKit_Private)

Drop all the category names.