[webkit-reviews] review requested: [Bug 174415] [GStreamer] Review WebKitWebSource after r219252. : [Attachment 315450] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 14 11:03:51 PDT 2017
Charlie Turner <cturner at igalia.com> has asked for review:
Bug 174415: [GStreamer] Review WebKitWebSource after r219252.
https://bugs.webkit.org/show_bug.cgi?id=174415
Attachment 315450: Patch
https://bugs.webkit.org/attachment.cgi?id=315450&action=review
--- Comment #1 from Charlie Turner <cturner at igalia.com> ---
Created attachment 315450
--> https://bugs.webkit.org/attachment.cgi?id=315450&action=review
Patch
Must confess the history of multi-threading WKWS is quite confusing, this seems
like a minimally decent change which doesn't regress any tests or manual checks
I have. All of the locking is redundant now as well, and it seems a little
heavy-handed anyway. I would like to just remove it all as well, but perhaps
someone with more context can comment about it.
More information about the webkit-reviews
mailing list