[webkit-reviews] review granted: [Bug 174508] Increase CoreAudio render audio buffer sizes for WebRTC : [Attachment 315437] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174508: Increase CoreAudio render audio buffer sizes for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=174508

Attachment 315437: Patch

https://bugs.webkit.org/attachment.cgi?id=315437&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315437
  --> https://bugs.webkit.org/attachment.cgi?id=315437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315437&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:226
> +    return AudioSession::sharedSession().sampleRate() / 100;

This will result in a buffer size of 80 for 8K which is definitely too small.
50 might be better.

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:304
> +    // For the moment we do not need to configure speaker proc as we ar not
providing any reference data.

Nit: "we ar not" => "we are not"