[webkit-reviews] review granted: [Bug 174472] Bring mac expectations in-line with other platforms : [Attachment 315429] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 174472: Bring mac expectations in-line with other platforms
https://bugs.webkit.org/show_bug.cgi?id=174472

Attachment 315429: Patch

https://bugs.webkit.org/attachment.cgi?id=315429&action=review




--- Comment #10 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 315429
  --> https://bugs.webkit.org/attachment.cgi?id=315429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315429&action=review

r=me as long as there aren't a lot of test failures after this change lands
(that Ryan & Matt aren't willing to clean up).

> Tools/ChangeLog:10
> +	   The override order for Mac test expectations does not conform to the
pattern used by iOS,
> +	   GTK, Windows and WPE.

It would be good to list the "old way" and the "new way" directly in the
changelog here:

What the current structure would be for sierra wk2 expectations and test
results (once highsierra changes are landed):

platform/mac-wk2
platform/wk2
platform/mac-sierra
platform/mac-highsierra
generic

Proposed structure for sierra wk2 expectations and test results (once
highsierra changes are landed):

platform/mac-sierra-wk2
platform/mac-sierra
platform/mac-wk2
platform/wk2
generic

Maybe also give a before/after wk1 example as well (since "-wk1" suffix is
added in some places).