[webkit-reviews] review granted: [Bug 174501] [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static : [Attachment 315423] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 174501: [WTF] Newly added AtomicStringImpl should use BufferInternal static
string if StringImpl is static
https://bugs.webkit.org/show_bug.cgi?id=174501

Attachment 315423: Patch

https://bugs.webkit.org/attachment.cgi?id=315423&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 315423
  --> https://bugs.webkit.org/attachment.cgi?id=315423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315423&action=review

> Source/WTF/wtf/text/AtomicStringImpl.cpp:128
>      const CharacterType* s;

Seems like this should be named "characters" or "string" rather than a single
letter. Worth coming back to and cleaning up some day.