[webkit-reviews] review granted: [Bug 173697] [GCrypt] Implement CryptoKeyRSA PKCS#8 exports : [Attachment 315340] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173697: [GCrypt] Implement CryptoKeyRSA PKCS#8 exports
https://bugs.webkit.org/show_bug.cgi?id=173697

Attachment 315340: Patch

https://bugs.webkit.org/attachment.cgi?id=315340&action=review




--- Comment #12 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 315340
  --> https://bugs.webkit.org/attachment.cgi?id=315340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315340&action=review

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:517
> +	   if (!PAL::TASN1::writeElement(pkcs8,
"privateKeyAlgorithm.parameters", "\x05\x00", 2))

"\x05\x00" could be a constant. You can do it separately.