[webkit-reviews] review granted: [Bug 173696] [GCrypt] Implement CryptoKeyRSA PKCS#8 imports : [Attachment 315339] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173696: [GCrypt] Implement CryptoKeyRSA PKCS#8 imports
https://bugs.webkit.org/show_bug.cgi?id=173696

Attachment 315339: Patch

https://bugs.webkit.org/attachment.cgi?id=315339&action=review




--- Comment #9 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 315339
  --> https://bugs.webkit.org/attachment.cgi?id=315339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315339&action=review

Looks good to me. r=me. Please address my comments in a followup patch.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:337
> +	   if (version->size() != 1 || version->at(0) != 0x00)

Please do a follow up patch to replace the 0x00 with a constant in all the
places. Using memcmp here is more ideal.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:368
> +	   if (version->size() != 1 || version->at(0) != 0x00)

Ditto.