[webkit-reviews] review granted: [Bug 174497] Web Automation: FindNodes should throw an error in case of invalid strategy : [Attachment 315411] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174497: Web Automation: FindNodes should throw an error in case of invalid
strategy
https://bugs.webkit.org/show_bug.cgi?id=174497

Attachment 315411: Patch

https://bugs.webkit.org/attachment.cgi?id=315411&action=review




--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 315411
  --> https://bugs.webkit.org/attachment.cgi?id=315411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315411&action=review

r=me

This does not affect safaridriver because it validates the strategy argument
prior to calling the atom. But this shouldn't do any harm, either.

> Source/WebKit/UIProcess/Automation/atoms/FindNodes.js:55
> +	   // 12.2 Find Element and 12.3 Find Elements: If location strategy is
not present as a keyword

Please write section numbers like §12.2 if possible. and mention step 4. I
don't think you need to include the URL here if it's in the commit message for
the change.

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:277
> +	   else if (exceptionName->string() == "InvalidParameter")

As long as this maps to "invalid argument", then this should be fine to reuse.