[webkit-reviews] review granted: [Bug 174494] Report CoreAudioCaptureSource failure in case shared unit stops to work properly : [Attachment 315403] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174494: Report CoreAudioCaptureSource failure in case shared unit stops to
work properly
https://bugs.webkit.org/show_bug.cgi?id=174494

Attachment 315403: Patch

https://bugs.webkit.org/attachment.cgi?id=315403&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315403
  --> https://bugs.webkit.org/attachment.cgi?id=315403
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315403&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:192
> +    m_didCaptureFailed = true;

Nit: "did capture failed" isn't right so maybe "m_captureFailed" or
"m_captureDidFail"?

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:146
> +    bool didCaptureFailed() const { return m_didCaptureFailed; }

Ditto.