[webkit-reviews] review requested: [Bug 174499] Web Automation: link and partial link queries don't work if text link contains trailing or leading whitespaces : [Attachment 315414] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 174499: Web Automation: link and partial link queries don't work if text
link contains trailing or leading whitespaces
https://bugs.webkit.org/show_bug.cgi?id=174499

Attachment 315414: Patch

https://bugs.webkit.org/attachment.cgi?id=315414&action=review




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 315414

  --> https://bugs.webkit.org/attachment.cgi?id=315414&action=review

Patch

This won't apply because it depends on patch attached to bug #174498. Note also
that this still doesn't fix
test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace, but now it
fails because of our poor implementation of GetText:

===============================================================================
=========== FAILURES
===============================================================================
===========
_______________________________________________________
test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace[WebKitGTK]
________________________________________________________

driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver
(session="e5b70972-d8f7-4de9-8324-d6f4e3607345")>, pages = <conftest.Pages
object at 0x7f3257a58490>

    def
test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace(driver,
pages):
	pages.load("simpleTest.html")
	link = driver.find_element(By.LINK_TEXT, "link with trailing space")
	assert link.get_attribute("id") == "linkWithTrailingSpace"
>	assert link.text == "link with trailing space"
E	assert 'link with trailing space ' == 'link with trailing space'
E	  - link with trailing space 
E	  ?			    -
E	  + link with trailing space

selenium/webdriver/common/driver_element_finding_tests.py:568: AssertionError