[webkit-reviews] review granted: [Bug 174284] media element handle adding source immediately before src. : [Attachment 315399] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 174284: media element handle adding source immediately before src.
https://bugs.webkit.org/show_bug.cgi?id=174284

Attachment 315399: Patch

https://bugs.webkit.org/attachment.cgi?id=315399&action=review




--- Comment #15 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 315399
  --> https://bugs.webkit.org/attachment.cgi?id=315399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315399&action=review

r=me assuming iOS sim failure isn’t this.

> LayoutTests/media/video-source-before-src.html:12
> +var video

Nit: Add semi-colon.

> LayoutTests/media/video-source-before-src.html:15
> +    video = document.getElementsByTagName("video")[0]

Nit: semi-colon

> LayoutTests/media/video-source-before-src.html:19
> +    video.src = "src.mp4"

Nit on above e lines: semi-colon