[webkit-reviews] review granted: [Bug 174487] Better deal with changes to the ResourceLoadStatisticsStore file on disk : [Attachment 315398] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 174487: Better deal with changes to the ResourceLoadStatisticsStore file on
disk
https://bugs.webkit.org/show_bug.cgi?id=174487

Attachment 315398: Patch

https://bugs.webkit.org/attachment.cgi?id=315398&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 315398
  --> https://bugs.webkit.org/attachment.cgi?id=315398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315398&action=review

Looks good! R=me

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:130
> +    int m_monthDay { 0 }; // [1, 31].

Is this really 1-based? If we are, why is t it initialized with a 1?