[webkit-reviews] review granted: [Bug 174418] [HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly : [Attachment 315321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 13 19:03:22 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 174418: [HarfBuzz] Decomposed Vietnamese characters are rendered
incorrectly
https://bugs.webkit.org/show_bug.cgi?id=174418

Attachment 315321: Patch

https://bugs.webkit.org/attachment.cgi?id=315321&action=review




--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 315321
  --> https://bugs.webkit.org/attachment.cgi?id=315321
Patch

I'm giving r+ even though I don't understand the code, because I'm pretty sure
we don't have any Igalia reviewers who might understand it. Myles, if you see
any reason not to commit this, please say so.

I have a suspicion that this commit might affect a lot of test results, so we
will need to watch the bots carefully after landing it. So we will have to try
landing this another day.


More information about the webkit-reviews mailing list