[webkit-reviews] review granted: [Bug 174452] Clean-up some things in GraphicsContext3D : [Attachment 315326] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 174452: Clean-up some things in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=174452

Attachment 315326: Patch

https://bugs.webkit.org/attachment.cgi?id=315326&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 315326
  --> https://bugs.webkit.org/attachment.cgi?id=315326
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315326&action=review

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:-576
> -#if USE(COORDINATED_GRAPHICS_THREADED)
> -	   ::glDeleteTextures(1, &m_compositorTexture);
> -#endif

Why can this go away?

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:315
> +    ASSERT(width >= 0 && height >= 0);

Can this assert fire if JS passes bad values from script? If so, don't assert.