[webkit-reviews] review granted: [Bug 174463] [GTK] Fix compiler warnings when building with GCC 7 : [Attachment 315366] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 174463: [GTK] Fix compiler warnings when building with GCC 7
https://bugs.webkit.org/show_bug.cgi?id=174463

Attachment 315366: Patch

https://bugs.webkit.org/attachment.cgi?id=315366&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 315366
  --> https://bugs.webkit.org/attachment.cgi?id=315366
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315366&action=review

This patch probably should not have [GTK] on it, since it’s not in
platform-specific code even if it’s for the benefit of ports that can use gcc.

> Source/cmake/OptionsCommon.cmake:78
> +	   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-noexcept-type")

Is this working around a bug, or what?