[webkit-reviews] review granted: [Bug 174395] REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests : [Attachment 315243] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 174395: REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton
related tests
https://bugs.webkit.org/show_bug.cgi?id=174395

Attachment 315243: Patch

https://bugs.webkit.org/attachment.cgi?id=315243&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 315243
  --> https://bugs.webkit.org/attachment.cgi?id=315243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315243&action=review

> Source/WebCore/ChangeLog:15
> +	   Before r219332 the height of the spin button was calculated as
> +	   the maximum value between the arrow width (33 pixels) and the
> +	   arrow height (16 pixels).
> +	   r219332 caused the height to be calculated as the arrow height,
> +	   which was incorrect as the arrow should be first expanded
> +	   vertically to fit the preferred size of the spinbutton widget.

There are no arrows in spin buttons, I guess you mean just the spin button
itself here.