[webkit-reviews] review denied: [Bug 174407] H264VideoToolboxDecoder::Decode has a memory leak when homing out on iOS : [Attachment 315310] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174407: H264VideoToolboxDecoder::Decode has a memory leak when homing out
on iOS
https://bugs.webkit.org/show_bug.cgi?id=174407

Attachment 315310: Patch

https://bugs.webkit.org/attachment.cgi?id=315310&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315310
  --> https://bugs.webkit.org/attachment.cgi?id=315310
Patch

Both callbacks are responsible for deleting the FrameDecodeParams* with this
design.  This is *very* bad.  We need to refcount instead if we give two
callbacks ownership of the object.