[webkit-reviews] review requested: [Bug 174385] Compute source frame info for frameless document : [Attachment 315292] Patch and layout test

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 174385: Compute source frame info for frameless document
https://bugs.webkit.org/show_bug.cgi?id=174385

Attachment 315292: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=315292&action=review




--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Created attachment 315292

  --> https://bugs.webkit.org/attachment.cgi?id=315292&action=review

Patch and layout test

The different order of delegate callbacks is due to the asynchronous nature of
frame loading. While we could fix up the test to enforce loads sequentially,
the purpose of this test is to ensure that we do not crash in
WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() when the frame
that initiated that navigation no longer exists. That is, the purpose of this
test is not to ensure an ordering of delegate callbacks. So, I moved the test
to LayoutTests/http/tests/navigation to avoid dumping the frame loader
callbacks.