[webkit-reviews] review granted: [Bug 174411] GenericArguments consults the wrong state when tracking modified argument descriptors and mapped arguments : [Attachment 315278] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 174411: GenericArguments consults the wrong state when tracking modified
argument descriptors and mapped arguments
https://bugs.webkit.org/show_bug.cgi?id=174411

Attachment 315278: patch

https://bugs.webkit.org/attachment.cgi?id=315278&action=review




--- Comment #13 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 315278
  --> https://bugs.webkit.org/attachment.cgi?id=315278
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315278&action=review

r=me

> JSTests/stress/generic-arguments-correct-delete-behavior.js:37
> +functions.push(makeTest(true, false, true));
> +functions.push(makeTest(false, false, true));
> +functions.push(makeTest(true, false, false));
> +functions.push(makeTest(false, false, false));

nit: please swap lines 34-35 with lines 36-37.	That makes it a bit easier to
follow the permutation of values.