[webkit-reviews] review granted: [Bug 174323] Accessing localDescription, remoteDescription, etc. after setTimeout raises EXC_BAD_ACCESS : [Attachment 315275] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174323: Accessing localDescription, remoteDescription, etc. after
setTimeout raises EXC_BAD_ACCESS
https://bugs.webkit.org/show_bug.cgi?id=174323

Attachment 315275: Patch

https://bugs.webkit.org/attachment.cgi?id=315275&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315275
  --> https://bugs.webkit.org/attachment.cgi?id=315275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315275&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:384
> +void PeerConnectionBackend::cleanPendingPromises()

Nit: rejectPendingPromises, or maybe clearPendingPromises, would be a more
accurate name.