[webkit-reviews] review granted: [Bug 174375] [MediaStream] a capture source failure should end the MediaStreamTrack : [Attachment 315259] Updated patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 174375: [MediaStream] a capture source failure should end the
MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=174375

Attachment 315259: Updated patch.

https://bugs.webkit.org/attachment.cgi?id=315259&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 315259
  --> https://bugs.webkit.org/attachment.cgi?id=315259
Updated patch.

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=315259&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:399
> +	   UserMediaProcessManager::singleton().endedCaptureSession(*this);

The only case that might not be handled here is if we stop capturing audio but
we start capturing video at the same time.
In that case, we are supposed to send the video extension but revoke the audio
one.

As a side note, it is surprising to have startedCaptureSession that does
nothing and endedCaptureSession that revokes extension.
Maybe we could do some future refactoring so that one grants extension and the
other revokes it.