[webkit-reviews] review granted: [Bug 173695] [GCrypt] Implement CryptoKeyRSA SPKI exports : [Attachment 314462] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173695: [GCrypt] Implement CryptoKeyRSA SPKI exports
https://bugs.webkit.org/show_bug.cgi?id=173695

Attachment 314462: Patch

https://bugs.webkit.org/attachment.cgi?id=314462&action=review




--- Comment #8 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 314462
  --> https://bugs.webkit.org/attachment.cgi?id=314462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314462&action=review

Looks good to me. r=me.

> Source/WebCore/ChangeLog:29
> +	   A helper mpiSignedData() function is added, providing overloads for
gcry_mpi_t

Interesting.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:304
> +	   if (!PAL::TASN1::writeElement(spki, "algorithm.algorithm",
"1.2.840.113549.1.1.1", 1))

Remember we should replace "1.2.840.113549.1.1.1" with a constant.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:308
> +	   if (!PAL::TASN1::writeElement(spki, "algorithm.parameters",
"\x05\x00", 2))

Another constant here?