[webkit-reviews] review denied: [Bug 173696] [GCrypt] Implement CryptoKeyRSA PKCS#8 imports : [Attachment 314029] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173696: [GCrypt] Implement CryptoKeyRSA PKCS#8 imports
https://bugs.webkit.org/show_bug.cgi?id=173696

Attachment 314029: Patch

https://bugs.webkit.org/attachment.cgi?id=314029&action=review




--- Comment #4 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 314029
  --> https://bugs.webkit.org/attachment.cgi?id=314029
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314029&action=review

Looks good to me. r- because of the duplicated function.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:244
> +static bool supportedAlgorithmIdentifier(const uint8_t* data, size_t size)

I believe this part is duplicated with Bug 173694. Please upload another patch
after that bug is resolved.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:297
> +	   if (version->size() != 1 || version->at(0) != 0x00)

See comments on Bug 173647.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:328
> +	   if (version->size() != 1 || version->at(0) != 0x00)

Ditto.