[webkit-reviews] review denied: [Bug 174128] [cmake] Use -pipe by default for compiling C++ files with g++ : [Attachment 314562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 12 10:42:48 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 174128: [cmake] Use -pipe by default for compiling C++ files with g++
https://bugs.webkit.org/show_bug.cgi?id=174128

Attachment 314562: Patch

https://bugs.webkit.org/attachment.cgi?id=314562&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 314562
  --> https://bugs.webkit.org/attachment.cgi?id=314562
Patch

Michael's comment needs to be addressed, and we need measurements of peak
memory use with and without -pipe and build time with and without -pipe. 
Please measure more than once.


More information about the webkit-reviews mailing list