[webkit-reviews] review granted: [Bug 174421] Web Automation: evaluateJavaScriptFunction should start the callback timeout after the function is applied : [Attachment 315235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 12 10:28:28 PDT 2017


Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174421: Web Automation: evaluateJavaScriptFunction should start the
callback timeout after the function is applied
https://bugs.webkit.org/show_bug.cgi?id=174421

Attachment 315235: Patch

https://bugs.webkit.org/attachment.cgi?id=315235&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 315235
  --> https://bugs.webkit.org/attachment.cgi?id=315235
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315235&action=review

r=me

For some reason, this test passes in safaridriver without the patch. I agree
that this is a valid fix though.

> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.js:54
> +	   let reportResult = (result) => { clearTimeout(timeoutIdentifier);
resultCallback(frameID, callbackID, this._jsonStringify(result), false);
resultReported = true; };

This is getting unwieldy, can you add newlines to the function?

The clearTimeout won't do anything if the function being evaluated calls the
callback/completion handler synchronously. I guess that's okay.


More information about the webkit-reviews mailing list