[webkit-reviews] review granted: [Bug 174426] Allow clients to override their own hardware media requirements where no fallback media exists. : [Attachment 315253] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 12 10:26:36 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 174426: Allow clients to override their own hardware media requirements
where no fallback media exists.
https://bugs.webkit.org/show_bug.cgi?id=174426
Attachment 315253: Patch
https://bugs.webkit.org/attachment.cgi?id=315253&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315253
--> https://bugs.webkit.org/attachment.cgi?id=315253
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=315253&action=review
r=me once it applies and compiles
> Source/WebCore/ChangeLog:9
> + Add a new Setting which allows clients to specify that their own
mediaContentTypesRequiringHardwareSupport in
Nit: don't need the "that" in "specify that their own".
> Source/WebKit/mac/ChangeLog:9
> + Add a new WebPreferences property able to control WebCore's new
Nit: don't need "able".
> Source/WebKit/mac/ChangeLog:10
> + allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.
Nit: "Setting" shouldn't be capitalized.
> Source/WebKit2/ChangeLog:10
> + WebCore's new
allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.
Ditto.
> Source/WebCore/html/HTMLMediaElement.h:173
> + void rejectPendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&,
DOMError&);
> + void resolvePendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&);
Did you mean to leave this in this patch?
More information about the webkit-reviews
mailing list