[webkit-reviews] review granted: [Bug 174386] NavigationAction should track whether the navigation was initiated by the main frame : [Attachment 315157] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 174386: NavigationAction should track whether the navigation was initiated
by the main frame
https://bugs.webkit.org/show_bug.cgi?id=174386

Attachment 315157: Patch

https://bugs.webkit.org/attachment.cgi?id=315157&action=review




--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 315157
  --> https://bugs.webkit.org/attachment.cgi?id=315157
Patch

In some places in this patch you change names:
e.g. m_navigationInitiatedByMainFrame becomes m_initiatedByMainFrame

I'm not sure why when the type remains "NavigationInitiatedByMainFrame"

I do think this flag of "initiated by main frame" has way more potential uses
besides navigation, so the name changes actually kind of make sense.

But please either change the typename as well, or leave the variable/method
names for now.