[webkit-reviews] review granted: [Bug 167963] [ESnext] Implement Object Spread : [Attachment 314907] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 11 16:28:36 PDT 2017


Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 167963: [ESnext] Implement Object Spread
https://bugs.webkit.org/show_bug.cgi?id=167963

Attachment 314907: Patch

https://bugs.webkit.org/attachment.cgi?id=314907&action=review




--- Comment #39 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 314907
  --> https://bugs.webkit.org/attachment.cgi?id=314907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314907&action=review

r=me

> Source/JavaScriptCore/parser/Parser.cpp:3878
> +	       TreeExpression elem =
parseAssignmentExpressionOrPropagateErrorClass(context);

Is this the grammar that's specified? If so, please add some more syntax tests
for what's inside an assignment expression.


More information about the webkit-reviews mailing list