[webkit-reviews] review granted: [Bug 174392] [SOUP] Do not use C linkage for functions using C++ features : [Attachment 315169] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 174392: [SOUP] Do not use C linkage for functions using C++ features
https://bugs.webkit.org/show_bug.cgi?id=174392

Attachment 315169: Patch

https://bugs.webkit.org/attachment.cgi?id=315169&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 315169
  --> https://bugs.webkit.org/attachment.cgi?id=315169
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315169&action=review

That's a good warning. Why can't GCC do that?

> Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61
> +// The following functions used from C++ only, they should be outside
> +// of the G_BEGIN_DECLS/G_END_DECLS block.

This should be obvious to anyone familiar with the intended use of
G_BEGIN_DECLS and G_END_DECLS, and it's a pattern we'll need to follow in many
private GObject header files wherever references are used in function
signatures, so I would remove the comment.