[webkit-reviews] review denied: [Bug 174333] Adjust unpartitioned cookie time-to-live to 48 hours : [Attachment 315047] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 174333: Adjust unpartitioned cookie time-to-live to 48 hours
https://bugs.webkit.org/show_bug.cgi?id=174333

Attachment 315047: Patch

https://bugs.webkit.org/attachment.cgi?id=315047&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 315047
  --> https://bugs.webkit.org/attachment.cgi?id=315047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:445
> +    store->setTimeToLiveCookiePartitionFree(48_h);

This is only used for testing. You need to update
WebResourceLoadStatisticsStore::m_timeToLiveCookiePartitionFree's default value
otherwise it won't do what you want.