[webkit-reviews] review granted: [Bug 172104] [WPE] Use libepoxy : [Attachment 314967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 11 12:01:51 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172104: [WPE] Use libepoxy
https://bugs.webkit.org/show_bug.cgi?id=172104

Attachment 314967: Patch

https://bugs.webkit.org/attachment.cgi?id=314967&action=review




--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 314967
  --> https://bugs.webkit.org/attachment.cgi?id=314967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314967&action=review

Nice! r=me, conditional on getting approval from Miguel as well.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
69
> +#if USE(LIBEPOXY)
> +// Include the <epoxy/gl.h> header before <gst/gl/gl.h>.
> +// Define GL_EXT_blend_func_extended since libepoxy headers don't, despite
> +// providing all the GL entrypoints and constants relevant to that
extension.
> +#include <epoxy/gl.h>
> +#define GL_EXT_blend_func_extended 1
> +#endif

Did you report a bug at https://github.com/anholt/libepoxy? Our friends at
Endless are maintaining libepoxy nowadays, so it should be easy to get changes
upstreamed. Let me know if you need me to ping Emmanuele.

> Source/cmake/OptionsWPE.cmake:78
> +find_package(LibEpoxy REQUIRED)

Do you know if a particular minimum version is required? That would be good to
research.

If 1.3.1 is new enough, then I think we could even make it a mandatory
dependency for WebKitGTK+. If you need 1.4, then it will have to remain
optional for a long time, because we need to support Ubuntu 16.04.


More information about the webkit-reviews mailing list