[webkit-reviews] review granted: [Bug 173648] [GCrypt] Implement CryptoKeyEC PKCS#8 exports : [Attachment 314461] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173648: [GCrypt] Implement CryptoKeyEC PKCS#8 exports
https://bugs.webkit.org/show_bug.cgi?id=173648

Attachment 314461: Patch

https://bugs.webkit.org/attachment.cgi?id=314461&action=review




--- Comment #10 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 314461
  --> https://bugs.webkit.org/attachment.cgi?id=314461
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314461&action=review

Looks good to me. r=me. Please address the following comments before landing.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:508
> +	   // Construct the EC context that we'll use to retrieve private and
public key data.

I believe private key should be ahead of parameters even though the end result
is the same.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:542
> +	   // Create the `SubjectPublicKeyInfo` structure.

Shouldn't it be "PrivateKeyInfo"?

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:553
> +	   if (!PAL::TASN1::writeElement(pkcs8,
"privateKeyAlgorithm.algorithm", "1.2.840.10045.2.1", 1))

Remember to make "1.2.840.10045.2.1" as a constant in a followup patch.