[webkit-reviews] review granted: [Bug 174306] Reset cookie partitioning state after network process crashes : [Attachment 315129] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 174306: Reset cookie partitioning state after network process crashes
https://bugs.webkit.org/show_bug.cgi?id=174306

Attachment 315129: Patch

https://bugs.webkit.org/attachment.cgi?id=315129&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 315129
  --> https://bugs.webkit.org/attachment.cgi?id=315129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315129&action=review

r=me if the bots are happy.

> Source/WebKit2/UIProcess/WebProcessPool.cpp:485
> +	   m_websiteDataStore->websiteDataStore().networkProcessDidCrash();

Using websiteDataStore() instead of m_websiteDataStore would look safer as it
returns a reference.

>
LayoutTests/http/tests/loading/resourceLoadStatistics/resources/get-cookies.php
:13
> +if(!isset($_COOKIE[$_GET["name3"]])) {

Could we also check that isset($_GET["name3"]) to avoid having to rebaseline
other tests that do not have a name3?