[webkit-reviews] review granted: [Bug 174368] Build broken when !ENABLE(VIDEO) : [Attachment 315122] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 174368: Build broken when !ENABLE(VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=174368

Attachment 315122: Patch

https://bugs.webkit.org/attachment.cgi?id=315122&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315122
  --> https://bugs.webkit.org/attachment.cgi?id=315122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review

> Source/WebCore/testing/Internals.h:445
>  #if ENABLE(VIDEO)
> +    Vector<String> mediaResponseSources(HTMLMediaElement&);

Can we make these [Conditional=VIDEO] too?  I think we're trying to move away
from using the C preprocessor on IDL files.