[webkit-reviews] review granted: [Bug 174356] Move USE_AVFOUNDATION definition on Windows to wtf/Platform.h : [Attachment 315108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 11 09:30:09 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Yoshiaki Jitsukawa
<Yoshiaki.Jitsukawa at sony.com>'s request for review:
Bug 174356: Move USE_AVFOUNDATION definition on Windows to wtf/Platform.h
https://bugs.webkit.org/show_bug.cgi?id=174356

Attachment 315108: Patch

https://bugs.webkit.org/attachment.cgi?id=315108&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 315108
  --> https://bugs.webkit.org/attachment.cgi?id=315108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315108&action=review

r=me

> Source/WTF/ChangeLog:13
> +	   * AVFoundationSupport.py: Renamed from
Source/WebCore/AVFoundationSupport.py.

Did you do a "svn mv" here? That should retain the update history. I can't tell
from this patch if you did or not.

I would also rephrase this as "Moved from Source/WebCore"


More information about the webkit-reviews mailing list