[webkit-reviews] review granted: [Bug 174363] [GTK][WPE] Align Jhbuild patches for GStreamer packages : [Attachment 315112] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 174363: [GTK][WPE] Align Jhbuild patches for GStreamer packages
https://bugs.webkit.org/show_bug.cgi?id=174363

Attachment 315112: Patch

https://bugs.webkit.org/attachment.cgi?id=315112&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 315112
  --> https://bugs.webkit.org/attachment.cgi?id=315112
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315112&action=review

> Tools/ChangeLog:14
> +	   This aligns the two ports on this specific issue. Next we'll look
into
> +	   creating a single GStreamer-specific Jhbuild moduleset that will
allow us
> +	   keeping these patches in a single place, avoiding duplicate files.

Oh come on, just upgrade to modern GStreamer and drop the patches.

I'd even prefer leaving some layout tests broken with a note saying they should
be fixed when we next upgrade GStreamer than applying patches downstream.