[webkit-reviews] review granted: [Bug 174357] [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile : [Attachment 315095] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174357: [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile
https://bugs.webkit.org/show_bug.cgi?id=174357

Attachment 315095: Patch

https://bugs.webkit.org/attachment.cgi?id=315095&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 315095
  --> https://bugs.webkit.org/attachment.cgi?id=315095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315095&action=review

> Source/WebCore/platform/glib/FileSystemGlib.cpp:430
> +    return (result != -1);

I would write these without the parens.

> Source/cmake/OptionsGTK.cmake:202
> +set(glib_components gio gio-unix gobject gthread gmodule)

I was going to say you can't use gio-unix unconditionally, but I guess you
actually can. I suppose gio-unix is available on Mac. OK then.