[webkit-reviews] review granted: [Bug 173572] [GTK] Spin buttons on input type number appear over the value itself for small widths : [Attachment 315106] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 173572: [GTK] Spin buttons on input type number appear over the value
itself for small widths
https://bugs.webkit.org/show_bug.cgi?id=173572

Attachment 315106: Patch

https://bugs.webkit.org/attachment.cgi?id=315106&action=review




--- Comment #27 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 315106
  --> https://bugs.webkit.org/attachment.cgi?id=315106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315106&action=review

> Source/WebCore/ChangeLog:10
> +	   This ensures that we don't end clovering the input values with

I'm not an English expert at all, but I think here we should say "end up"

> Source/WebCore/rendering/RenderThemeGtk.cpp:939
> +    // Input field need a minimum dimensions to render the spinbuttons
correctly (without clovering the values).

need a minimum dimensions -> need minimum dimensions

> Source/WebCore/rendering/RenderThemeGtk.cpp:957
> +    // renders on WebKitGTK+. To ensure that spin buttons don't end
clovering the values of the input

Same comment here about "end up"