[webkit-reviews] review granted: [Bug 173861] We should do ICE candidate filtering at the Document level : [Attachment 315082] Keeping controller at page

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 173861: We should do ICE candidate filtering at the Document level
https://bugs.webkit.org/show_bug.cgi?id=173861

Attachment 315082: Keeping controller at page

https://bugs.webkit.org/attachment.cgi?id=315082&action=review




--- Comment #15 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315082
  --> https://bugs.webkit.org/attachment.cgi?id=315082
Keeping controller at page

View in context: https://bugs.webkit.org/attachment.cgi?id=315082&action=review

> Source/WebCore/ChangeLog:25
> +	   Making UserMediaRequest disable the ICE candidate filtering for the
page RTCController.
> +	   All RTCPeerConnection of the page that are created on a document
that are same-origin as the top document are now registered to the
RTCController.
> +	   This allows disabling filtering to only these RTCPeerConnection.
> +
> +	   The page keeps the default ICE candidate filtering policy.
> +	   This policy allows disabling ICE candidate filtering for all
RTCPeerConnection.
> +
> +	   When the top document is changing, the RTCController filtering
policy is reset and its list of RTCPeerConnection is emptied.
> +
> +	   Internals no longer disables ICE candidate filtering by default.
> +	   This allows finer grained testing.
> +	   ICE candidate filtering is disabled for tests including
testharnessreport.js to enable web-platform-tests to run without modifications.

Nit: please wrap these lines to make them easier to read.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:72
> +	   // ICE candidate filtering can only be disabled for connections from
documents that have the same origin as the top document, or if the page was set
to disable it.

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:585
>  #if ENABLE(WEB_RTC)
>  void WebPage::disableICECandidateFiltering()
>  {
> -    m_page->rtcController().disableICECandidateFiltering();
> +    m_page->disableICECandidateFiltering();
>  }
>  
>  void WebPage::enableICECandidateFiltering()
>  {
> -    m_page->rtcController().disableICECandidateFiltering();
> +    m_page->enableICECandidateFiltering();
>  }

Are these needed now that UserMediaProcessManager is no longer involved in
managing filtering?