[webkit-reviews] review granted: [Bug 174349] Changing the web page muted state for playing audio should not disable other tabs capture : [Attachment 315083] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 11 06:03:18 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 174349: Changing the web page muted state for playing audio should not
disable other tabs capture
https://bugs.webkit.org/show_bug.cgi?id=174349

Attachment 315083: Patch

https://bugs.webkit.org/attachment.cgi?id=315083&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 315083
  --> https://bugs.webkit.org/attachment.cgi?id=315083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315083&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4147
> +    bool hasMutedCaptureStreams = (m_mediaState &
WebCore::MediaProducer::HasMutedAudioCaptureDevice) || (m_mediaState &
WebCore::MediaProducer::HasMutedVideoCaptureDevice);

Nit: "bool hasMutedCaptureStreams = m_mediaState &
(WebCore::MediaProducer::HasMutedAudioCaptureDevice |
WebCore::MediaProducer::HasMutedVideoCaptureDevice);" would be slightly easier
to read


More information about the webkit-reviews mailing list