[webkit-reviews] review granted: [Bug 174312] Factor common code in Style::*ChangeInvalidation into helper functions : [Attachment 314993] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 174312: Factor common code in Style::*ChangeInvalidation into helper
functions
https://bugs.webkit.org/show_bug.cgi?id=174312

Attachment 314993: patch

https://bugs.webkit.org/attachment.cgi?id=314993&action=review




--- Comment #3 from Andreas Kling <akling at apple.com> ---
Comment on attachment 314993
  --> https://bugs.webkit.org/attachment.cgi?id=314993
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314993&action=review

r=me

> Source/WebCore/style/StyleInvalidationFunctions.h:38
> +template <typename Function>
> +inline void traverseRuleFeaturesInShadowTree(Element& element, Function&&
function)

Does the Function argument need to be templated when you're only ever using it
to pass a void(RuleFeatureSet&,bool)?