[webkit-reviews] review granted: [Bug 174286] [WK2 iOS] During momentum scroll, getBoundingClientRect returns wrong coordinates (missing images on pinterest, elle.com and many other sites) : [Attachment 315065] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 174286: [WK2 iOS] During momentum scroll, getBoundingClientRect returns
wrong coordinates (missing images on pinterest, elle.com and many other sites)
https://bugs.webkit.org/show_bug.cgi?id=174286

Attachment 315065: Patch

https://bugs.webkit.org/attachment.cgi?id=315065&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 315065
  --> https://bugs.webkit.org/attachment.cgi?id=315065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315065&action=review

> Source/WebCore/ChangeLog:19
> +	   but fix the scrolling tree logic to work correctly in this cause.

Typo: cause

>
LayoutTests/fast/visual-viewport/ios/get-bounding-client-rect-unstable.html:49
> +	       testRunner.runUIScript(simulateScrollingStart(500), function() {
> +		   checkBoundingClientRect(-150);
> +
> +		   debug('Finishing scroll');
> +		   testRunner.runUIScript(simulateScrollingEnd(), function() {

Is it ok to call a UIScript from within a UIScript?