[webkit-reviews] review denied: [Bug 174315] check-webkit-style: cpp linter incorrectly treats colon appearing in a string argument as the start of the initializer list : [Attachment 315052] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 10 17:50:29 PDT 2017
Matt Baker <mattbaker at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 174315: check-webkit-style: cpp linter incorrectly treats colon appearing
in a string argument as the start of the initializer list
https://bugs.webkit.org/show_bug.cgi?id=174315
Attachment 315052: Patch
https://bugs.webkit.org/attachment.cgi?id=315052&action=review
--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 315052
--> https://bugs.webkit.org/attachment.cgi?id=315052
Patch
r- for now.
Need to improve on this (using elided over raw_lines feels risky), and add a
test case to Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py.
More information about the webkit-reviews
mailing list