[webkit-reviews] review granted: [Bug 174311] Web Inspector: Refactoring: replace InspectorCanvasAgent::CanvasEntry with a helper class : [Attachment 315000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 10 14:19:19 PDT 2017


Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 174311: Web Inspector: Refactoring: replace
InspectorCanvasAgent::CanvasEntry with a helper class
https://bugs.webkit.org/show_bug.cgi?id=174311

Attachment 315000: Patch

https://bugs.webkit.org/attachment.cgi?id=315000&action=review




--- Comment #16 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 315000
  --> https://bugs.webkit.org/attachment.cgi?id=315000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315000&action=review

r=me

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:241
> +    for (auto& inspectorCanvas : inspectorCanvases) {

Shouldn't this be an `auto*`?


More information about the webkit-reviews mailing list