[webkit-reviews] review denied: [Bug 174233] Add location to NavigationActionData : [Attachment 314998] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 174233: Add location to NavigationActionData
https://bugs.webkit.org/show_bug.cgi?id=174233

Attachment 314998: Patch

https://bugs.webkit.org/attachment.cgi?id=314998&action=review




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314998
  --> https://bugs.webkit.org/attachment.cgi?id=314998
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314998&action=review

> Source/WebCore/ChangeLog:9
> +	   Add the root view location of a tap to a NavigationAction to vend to
Safari.
> +
> +	   Reviewed by NOBODY (OOPS!).

Swap these two lines around.

> Source/WebCore/ChangeLog:11
> +	   Test: small enough change to not be tested alone.

But you could write an API test for it.

> Source/WebCore/dom/MouseRelatedEvent.h:60
> +    WEBCORE_EXPORT IntPoint absoluteLocationConvertedToRootView() const;

The fact that it's computed from absolute coords is not relevant to the caller;
this should just be called locationInRootViewCoordinates(), and should return a
FloatPoint (since converting to root view may go through transforms).