[webkit-reviews] review granted: [Bug 174300] [WK2] Ignore touch events that interrupt platform-driven momentum scrolling : [Attachment 314957] First pass

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174300: [WK2] Ignore touch events that interrupt platform-driven momentum
scrolling
https://bugs.webkit.org/show_bug.cgi?id=174300

Attachment 314957: First pass

https://bugs.webkit.org/attachment.cgi?id=314957&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 314957
  --> https://bugs.webkit.org/attachment.cgi?id=314957
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=314957&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4058
> +// FIXME: Remove once -gestureRecognizer:shouldIgnoreWebTouchWithEvent: is
in UIWebTouchEventsGestureRecognizer.h.

Would be nice to have a radar number here.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4067
> +    NSSet<UITouch *> *webTouches = [event
touchesForGestureRecognizer:gestureRecognizer];
> +    for (UITouch *webTouch in webTouches) {

I think "webTouches" and "webTouch" could just be "touches" and "touch".