[webkit-reviews] review granted: [Bug 174279] Web Inspector: Highlight matching CSS canvas clients when hovering contexts in the Resources tab : [Attachment 314994] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 174279: Web Inspector: Highlight matching CSS canvas clients when hovering
contexts in the Resources tab
https://bugs.webkit.org/show_bug.cgi?id=174279

Attachment 314994: Patch

https://bugs.webkit.org/attachment.cgi?id=314994&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 314994
  --> https://bugs.webkit.org/attachment.cgi?id=314994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314994&action=review

r=me, with nits.

> Source/JavaScriptCore/ChangeLog:9
> +	    - Add `highlightNodeList` command that will highlight each node in
the given list.

Nit: drop the ` - `

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1168
> +	       ASSERT(errorString.length());

This assert is unnecessary. `errorString` is always set.

> LayoutTests/inspector/dom/highlightNodeList.html:47
> +	   description: "Should not be a highlight yet.",

What about: "Check that highlight list is initially empty."

> LayoutTests/inspector/dom/highlightNodeList.html:50
> +		   InspectorTest.expectEqual(highlightObjectPayload.length, 0,
"Should not be a highlight yet.");

What about: "Highlight should not exist."