[webkit-reviews] review granted: [Bug 174295] Block of text is missing in iBooks sample books. : [Attachment 314958] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 174295: Block of text is missing in iBooks sample books.
https://bugs.webkit.org/show_bug.cgi?id=174295

Attachment 314958: Patch

https://bugs.webkit.org/attachment.cgi?id=314958&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 314958
  --> https://bugs.webkit.org/attachment.cgi?id=314958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314958&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> +    // Did we miss the line?
> +    if (y < bottom && !lastIndexCandidate) {
> +	   ASSERT_NOT_REACHED();
> +	   return lineIndexCandidate;
>      }

Should turn this into pure assert post-branch.