[webkit-reviews] review granted: [Bug 174307] [WK2] Action sheets for links fail to present in WebKit2 PDF view : [Attachment 314964] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174307: [WK2] Action sheets for links fail to present in WebKit2 PDF view
https://bugs.webkit.org/show_bug.cgi?id=174307

Attachment 314964: Patch

https://bugs.webkit.org/attachment.cgi?id=314964&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 314964
  --> https://bugs.webkit.org/attachment.cgi?id=314964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314964&action=review

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:374
> +	   if (![_interactionSheet
presentSheet:computePresentationStyleForView(_view.getAutoreleased(),
_positionInformation.value(), _elementInfo.get())])

Drop the needless “compute” prefix and I’m sold :)