[webkit-reviews] review granted: [Bug 174298] It should be easy to decide how WebKit yields : [Attachment 314950] the.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 9 18:26:57 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 174298: It should be easy to decide how WebKit yields
https://bugs.webkit.org/show_bug.cgi?id=174298

Attachment 314950: the.patch

https://bugs.webkit.org/attachment.cgi?id=314950&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 314950
  --> https://bugs.webkit.org/attachment.cgi?id=314950
the.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314950&action=review

r=me with comment about windows fix.

> Source/WTF/wtf/Threading.cpp:190
> +void Thread::yield()
> +{
> +    sched_yield();
> +}

`sched_yield` is not defined in Windows.
So, let's define this in ThreadingPthreads.cpp. And in ThreadingWin.cpp, let's
define it with SwitchToThread().


More information about the webkit-reviews mailing list